So first some background to aid in understanding. When you join the NRA, you have contributed basically nothing to the legal and political fight for RKBA. That entity isn't legally allowed to do much in that arena. That falls to NRA-ILA, and if you want to donate money to he NRA to affect political change, you should be donating there. The main good the membership part of the NRA does is helping shooting ranges operate. Either via expert input on how to get one built, grants, or access to insurance. Regardless of which of those things you might be donating to, don't reactively donate. Go find the donate button and make a donation. If someone asked you first, it is pretty much guaranteed less of your dollars make it to where you want it to go.
Outside of having run the organization so poorly as to put it at peril while mismanaging everyone's contributions, the NRA basically operates on the model of mitigating damage. You don't launch a lawsuit that might set bad precedent. You don't say no to legislation, you ride it into the ground trying to make it less bad. This has worked like shit.
So who else is worth donating to?
Nationally, the two biggies are the second amendment foundation, and the firerarms policy coalition with gun owners of america stumbling in at third place.
The SAF is pretty much focused only on court cases, and seems to be very, very conservative about the cases they initiate, but seems to be seem to be more productive in usefully joining onto suits that didn't originate with them that have some legs. They seem to largely be beating their head against the 9th circuit for a while though. So unless that is a longer term strategy I don't understand, I'm not terribly pleased with the performance in the last few years.
Then there is FPC. They seem to be a bit light on lobbying, but appear to still engage in it. They also are a lot more aggressive in pursuing litigation. They may not have won us anything huge yet, but they also haven't screwed us yet. They seem to exercise some decent judgement about the cases they take and they seem to be willing to back multiple horses on a given issue rather than waiting for an ideal case/defendant. As time goes on, they don't seem to be stupid, and they seem to grasp that you can't make the shots you don't take. Also if you read their mission statement, it seems pretty sound and non partisan.
GOA is more about lobbying and making headlines. They are brash and kind of annoying at times, but they get attention. It's hard to tell if they carry any weight lobbying or if they are just running around me-tooing everything and sending out press releases when the winds blow their way. They do seem to be shaping up to being the most agile in terms mustering coordinated group yelling at congress, so that's something in their favor. The major downside for them is that they are effectively owned by an individual, which isn't the best plan for a durable and robust organization.
There are no real membership benefits to the above, and I suspect they don't ever remove anyone from the rolls kind of like the gun grabbers don't. I've also never gotten a membership renewal request from any of them. the SAF does seem to waste the most money on sending me junk mail. So I haven't bothered to renew my membership to any of them. My general strategy is that I have a budget for donating money for RKBA activism, and at a minimum they all get a Christmas gift of $25. I then make smaller additional donations throughout the year as rewards. If I see a lawsuit I like the looks of and it was launched by FPC, they get another donation. Same for SAF. GOA tends to not get media based donations from me, but occasionally earns some extra cash by getting me useful information fast on federal actions.
Locally, we have had a ton of groups stumble through. Many of them absolutely awful and they go away.
ANJRPC is the state NRA affiliate. The kindest thing I can say about them is I think they finally got the message that the gun owners of NJ weren't impressed by how they were doing things. They seem to have departed a bit from the mother ship's playbook of focusing on legislation and mitigating harm, and have joined in poking the bear to generate legal challenges. But there's a lot of bad blood between ANJRPC and NJ gunowners as for a very long period, there wasn't much evidence they existed outside of their association with a single gun range and official legal filings.
Then there is NJ2AS, which as far as I can tell spearheaded the shift to organized legal challenges in NJ to try and make something actionable happen to challenge the law. It appears to consist largely of Alex, and his traffic accident underscores my concern about any group that is basically owned and operated by an individual.
There also always seems to be a perpetual churn of the designated fudd group that only cares about guns and hunting. That seems to currently be the NJOA, but they can't even keep a website up at the moment it seems. While some of the more prominent ones in the past got big enough to generate proof that stupid people in larger groups are dangerous, I'm not sure that these groups aren't just shills for whomever.
Then there is the CNJFO. Which seems to have come on the scene to promote community outreach and to try and get the various other organizations to play nice with each other. Their appearance seems to coincide with NJ2AS and ANJRPC starting to appear to have some strategies in common.
Here I don't have a good answer. CNJFO got my money this last year, but that is in part because they are the newest face in town and I know some of the people involved. The rest of my state activism budget went to crowdfunding specific lawsuits.
I always make sure my amazon smile is always pointing at something pro 2a, and make a point to donate at least the market rate for a case of ammo each year to a variety of groups. The NRA made it clear that not having a plan B is a shit plan.